feat: Add regrid_Sv functionality to be able to regrid Sv dataset
#1291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1291 +/- ##
===========================================
- Coverage 83.80% 70.38% -13.42%
===========================================
Files 64 11 -53
Lines 5705 824 -4881
===========================================
- Hits 4781 580 -4201
+ Misses 924 244 -680
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@leewujung This is currently a draft PR because I don't have tests for it yet. However, could you please start reviewing the implementation and help me try out different scenarios to make sure I have it implemented correctly? Thanks! |
|
@lsetiawan : Could you put in at least a couple test so that it's easier to step through the code? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR add regridding functionality for existing Sv data